This repository was archived by the owner on Feb 15, 2023. It is now read-only.
Add namespace feature SocketIOConnection.#19
Open
ghqian wants to merge 1 commit intouhm0311:developfrom
Open
Conversation
Reason: When you use url like http://localhost:3000/ the socket.io client will create a websocket transport url like ws://localhost:3000/socket.io. It will work fine. But when you have url like http://localhost:3000/march, then the websocket transport url is also ws://localhost:3000/socket.io but with namespace "/march". And onConnection event in client may need connect signal for namespace "/" and also "/march". After then the emit from server can use namespace "/march" in its packets, and the client will react to namespace "/march" emit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason:
When you use url like http://localhost:3000/ the socket.io client will create a websocket transport url like ws://localhost:3000/socket.io.
It will work fine.
But when you have url like http://localhost:3000/march, then the websocket transport url is also ws://localhost:3000/socket.io but with namespace "/march".
And onConnection event in client may need connect signal for namespace "/" and also "/march".
After then the emit from server can use namespace "/march" in its packets, and the client will react to namespace "/march" emit.